Conversation
|
Not sure why the build fails on this @andyleejordan ? In csproj the SMA reference used to be conditional based on the target framework so don't understand how it even works now with the current 7.2 target that should only apply for PowerShell 7 builds but not 3, etc On another note, what do you think about a new release now that we've merged all the recent PRs? The SMA update is the only one I was thinking of doing before the release. |
It seems the GitHub Actions Ubuntu image is failing to add
Yes, planning on it. |
| @@ -11,7 +11,7 @@ | |||
| <PackageVersion Include="Newtonsoft.Json" Version="13.0.3" /> | |||
| <PackageVersion Include="Pluralize.NET" Version="1.0.2" /> | |||
| <PackageVersion Include="PowerShellStandard.Library" Version="3.0.0-preview-02" /> | |||
There was a problem hiding this comment.
Side note, are we stuck on this version because of PowerShell 3 support? If not let's update it to 5.1.1.
There was a problem hiding this comment.
Yes. Although it was an improvement to have as not all projects had to reference the psv3/4/5 reference assemblies. since it's just for referencing and not shipped, I don't mind TBH. Regarding dropping support, how about we start soft and just bump the minimum version in manifest and see what people's feedback is?
2 participants
PR Summary
Since PowerShell 7.2 is not supported any more, we can upgrade the SMA version. Somehow 7.4.8 is not published, raised issue here: PowerShell/PowerShell#25162
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.